Skip to content

fix(connector): use the right schema for delete parameters #21566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kwannoel wants to merge 6 commits into from
Closed

fix(connector): use the right schema for delete parameters #21566

kwannoel wants to merge 6 commits into from

Conversation

@kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Apr 25, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We use all fields of a schema instead of just pk fields previously to generate delete statements. This PR fixes that.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@kwannoel kwannoel mentioned this pull request Apr 25, 2025
Merged
8 tasks
@kwannoel Graphite App
Copy link
Contributor Author

kwannoel commented Apr 25, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kwannoel kwannoel mentioned this pull request Apr 25, 2025
Closed
8 tasks
@kwannoel kwannoel changed the title refactor out prepare statement fix(connector): use the right schema for delete parameters Apr 25, 2025
@kwannoel kwannoel marked this pull request as ready for review April 25, 2025 03:55
@github-actions github-actions bot added type/fix Type: Bug fix. Only for pull requests. and removed Invalid PR Title labels Apr 25, 2025
@kwannoel kwannoel force-pushed the kwannoel/fix_delete_parameters branch from 37fed5e to 861d1f2 Compare April 25, 2025 05:11
@kwannoel kwannoel force-pushed the kwannoel/on_insert_do_update branch from b21d6ad to 535c9ef Compare April 25, 2025 05:11
chenzl25
chenzl25 approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR looks more like a performance improvement instead of a fix.

@kwannoel
Copy link
Contributor Author

kwannoel commented Apr 29, 2025

Merged via #21543

@kwannoel kwannoel closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenzl25 chenzl25 chenzl25 approved these changes

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

@zwang28 zwang28 Awaiting requested review from zwang28

Assignees

No one assigned

Labels

type/fix Type: Bug fix. Only for pull requests. type/refactor Type: Refactoring.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwannoel @chenzl25