Skip to content

Conversation

@tylernij
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@lancesnider lancesnider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but looks good.

There's no data binding images demo in the rive-android example app, is there? If there is, lets link to it in snippets/demos.tsx

// Example method to toggle between light and dark mode images
public void ToggleTheme()
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this broke the code formatting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang it! I hate this mintlify thing!

The image data binding API in React Native is not yet available, and will likely only be supported in an upcoming rewrite of the package.
</Warning>
</Tab>
<Tab title="Android">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency can you put the Android tab after the Apple tab?

@tylernij
Copy link
Collaborator Author

@lancesnider Take a look now... I did it all through the mintlify CLI and checked it locally as well. Those Unity-related lines are still there, but they actually seem to be better formatted now? Previously that method was mistakenly indented back by one tab, now it's lined up with the other functions. I also added that demo link like you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants