-
Notifications
You must be signed in to change notification settings - Fork 23
docs(Android): add Android Image databinding sample #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, but looks good.
There's no data binding images demo in the rive-android example app, is there? If there is, lets link to it in snippets/demos.tsx
| // Example method to toggle between light and dark mode images | ||
| public void ToggleTheme() | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this broke the code formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang it! I hate this mintlify thing!
runtimes/data-binding.mdx
Outdated
| The image data binding API in React Native is not yet available, and will likely only be supported in an upcoming rewrite of the package. | ||
| </Warning> | ||
| </Tab> | ||
| <Tab title="Android"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency can you put the Android tab after the Apple tab?
Signed-off-by: Tyler Nijmeh <[email protected]>
a450204 to
6d65afc
Compare
|
@lancesnider Take a look now... I did it all through the mintlify CLI and checked it locally as well. Those Unity-related lines are still there, but they actually seem to be better formatted now? Previously that method was mistakenly indented back by one tab, now it's lined up with the other functions. I also added that demo link like you mentioned. |
No description provided.