Skip to content

fix: remove frn #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove frn #3106

wants to merge 1 commit into from

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Oct 7, 2025 •
edited
Loading

TL;DR

Improved header handling in API clients by removing all Fern-related headers.

What changed?

  • Modified the cloud-data-provider.tsx to use a more robust approach for removing Fern-related headers by iterating through all headers and removing any that start with "x-fern-" (case-insensitive)
  • Fixed a typo in the cloud provider where fetcher was called instead of fetch
  • Added the same header cleaning logic to the engine-data-provider.tsx to ensure consistent behavior across both data providers

How to test?

  1. Make API calls using both cloud and engine data providers
  2. Verify that no "x-fern-" headers are being sent in the requests
  3. Confirm that API calls complete successfully with the updated header handling

Why make this change?

The previous implementation in the cloud provider only removed specific Fern headers by name, which could miss other Fern headers. The new implementation ensures all Fern-related headers are removed systematically. Adding this same functionality to the engine provider ensures consistent behavior across both providers and prevents potential issues with unwanted headers being sent to the API.

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-inspector Ready Ready Preview Comment Oct 13, 2025 6:22pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Preview Oct 13, 2025 6:22pm
rivet-site Ignored Ignored Preview Oct 13, 2025 6:22pm

@jog1t jog1t marked this pull request as ready for review October 7, 2025 22:41
@jog1t Graphite App
Copy link
Contributor Author

jog1t commented Oct 7, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 7, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3106

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3106

commit: fa2b93b

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Oct 7, 2025

Graphite Automations

"Test" took an action on this PR • (10/07/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from 140e5fe to dc1bc10 Compare October 7, 2025 22:45
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@vercel vercel bot temporarily deployed to Preview – rivet-inspector October 7, 2025 22:52 Inactive
@vercel vercel bot temporarily deployed to Preview – rivet-site October 7, 2025 22:52 Inactive
@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from dc1bc10 to bd2c76a Compare October 7, 2025 22:56
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from bd2c76a to e9830a4 Compare October 7, 2025 22:59
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@vercel vercel bot temporarily deployed to Preview – rivet-site October 7, 2025 23:04 Inactive
@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from e9830a4 to ed7cca1 Compare October 7, 2025 23:09
@claude Claude
Copy link

claude bot commented Oct 7, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t mentioned this pull request Oct 8, 2025
Open
@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from ed7cca1 to 58093a8 Compare October 8, 2025 20:34
@claude Claude
Copy link

claude bot commented Oct 8, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 9, 2025
Open
Open
Open
@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from 58093a8 to dbc747f Compare October 10, 2025 16:57
@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Oct 10, 2025
Closed
@jog1t jog1t mentioned this pull request Oct 10, 2025
Closed
@NathanFlurry NathanFlurry mentioned this pull request Oct 10, 2025
Closed
@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from dbc747f to 7f36cf5 Compare October 10, 2025 23:07
This was referenced Oct 10, 2025
Open
Open
@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 12, 2025
Closed
Closed
Closed
@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 10-08-fix_remove_frn branch from 90e8833 to fa2b93b Compare October 13, 2025 18:18
@claude Claude
Copy link

claude bot commented Oct 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 13, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees

@jog1t jog1t

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jog1t @NathanFlurry