Skip to content

fix: add skeleton (remove blinking) #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 10-09-feat_add_favicon
Choose a base branch
from
Open

fix: add skeleton (remove blinking) #3145

wants to merge 1 commit into from
+47 −29

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Oct 9, 2025 •
edited
Loading

TL;DR

Created a reusable PendingRouteLayout component to standardize loading states across routes.

What changed?

  • Extracted the loading skeleton UI from the organization route into a new PendingRouteLayout component
  • Applied this component to multiple routes for consistent loading states:
    • Organization route
    • Project route
    • Namespace route
  • Updated imports to include H2 and Skeleton components where needed
  • Made a minor text change in the provider dropdown, changing "Coming soon!" to "Soon!" for Vercel integration

How to test?

  1. Navigate between different routes in the application
  2. Verify that loading states appear consistently across:
    • Organization pages
    • Project pages
    • Namespace pages
  3. Check that the loading skeleton UI displays correctly with proper spacing and layout

Why make this change?

This change improves code reusability by centralizing the loading UI into a single component rather than duplicating it across multiple routes. It ensures a consistent user experience during loading states throughout the application, making the interface feel more cohesive and polished.

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud (staging) Ready Ready Preview Comment Oct 13, 2025 6:28pm
rivet-inspector Ready Ready Preview Comment Oct 13, 2025 6:28pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Preview Oct 13, 2025 6:28pm
rivet-site Ignored Ignored Preview Oct 13, 2025 6:28pm

This was referenced Oct 9, 2025
Open
Open
Open
Open
@jog1t jog1t marked this pull request as ready for review October 9, 2025 18:10
@claude Claude
Copy link

claude bot commented Oct 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t mentioned this pull request Oct 9, 2025
Open
@jog1t jog1t mentioned this pull request Oct 9, 2025
Open
@jog1t Graphite App
Copy link
Contributor Author

jog1t commented Oct 9, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t mentioned this pull request Oct 9, 2025
Open
@jog1t jog1t requested a review from NathanFlurry October 9, 2025 18:10
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Oct 9, 2025

Graphite Automations

"Test" took an action on this PR • (10/09/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 9, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3145

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3145

commit: f2838a1

@jog1t jog1t force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from 1a30377 to 886835c Compare October 9, 2025 18:17
@claude Claude
Copy link

claude bot commented Oct 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from 886835c to b37e7ea Compare October 9, 2025 19:04
@claude Claude
Copy link

claude bot commented Oct 9, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from b37e7ea to 4d2237e Compare October 10, 2025 16:57
@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Oct 10, 2025
Closed
@jog1t jog1t mentioned this pull request Oct 10, 2025
Closed
@NathanFlurry NathanFlurry mentioned this pull request Oct 10, 2025
Closed
@jog1t jog1t force-pushed the 10-09-feat_add_favicon branch from 067c0ec to c8ee586 Compare October 10, 2025 23:07
@jog1t jog1t force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from 4d2237e to c554433 Compare October 10, 2025 23:07
This was referenced Oct 10, 2025
Open
Open
@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from c554433 to 958a049 Compare October 12, 2025 20:58
@NathanFlurry NathanFlurry force-pushed the 10-09-feat_add_favicon branch from c8ee586 to 2c4a1ea Compare October 12, 2025 20:58
This was referenced Oct 12, 2025
Closed
Closed
Closed
@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from 958a049 to c203333 Compare October 12, 2025 21:21
@NathanFlurry NathanFlurry force-pushed the 10-09-feat_add_favicon branch from 2c4a1ea to 0a3f7d9 Compare October 12, 2025 21:21
@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 10-09-fix_add_skeleton_remove_blinking_ branch from c203333 to f2838a1 Compare October 13, 2025 18:18
@claude Claude
Copy link

claude bot commented Oct 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 13, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees

@jog1t jog1t

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jog1t