Fix Navigation Goal Rejection in sm_nav2_unit_test_1#689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Navigation goals were being rejected with the error:
[bt_navigator]: Action server is inactive. Rejecting the goal.
The state machine was transitioning from
StSetInitialPosetoStNavigateToWaypoint1before the Nav2 stack was fully active.
Root Cause
StSetInitialPoseusedCbWaitTransformto wait for themap→base_linktransform.This transform became available before the Nav2 lifecycle nodes (especially
bt_navigator) were activated, causing navigation goals to be rejected.Solution
Replaced
CbWaitTransformwithCbWaitNav2NodesinStSetInitialPose.CbWaitNav2Nodeswaits for critical Nav2 nodes to be active:This ensures the navigation stack is fully ready before attempting navigation.
Files Changed
st_set_initial_pose.hpp
Path:
smacc2_sm_reference_library/sm_nav2_unit_test_1/include/.../states/cb_wait_transform.hpptocb_wait_nav2_nodes.hppCbWaitNav2Nodesevents:EvCbSuccess<CbWaitNav2Nodes, OrNavigation>→ StNavigateToWaypoint1EvCbFailure<CbWaitNav2Nodes, OrNavigation>→ StSetInitialPose (retry)EvMaxRetriesExceeded<CbWaitNav2Nodes, OrNavigation>→ StFinalStatestaticConfigure()to useCbWaitNav2Nodesinstead ofCbWaitTransformpostEventcall in retry logic to use correct event typeTesting