Skip to content

Add realsense d435i MJCF. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kevinzakka
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8552222498

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 98.583%

Totals Coverage Status
Change from base Build 8520072047: 0.01%
Covered Lines: 974
Relevant Lines: 988

💛 - Coveralls

@stephane-caron
Copy link
Member

Thanks for this PR!

The realsense is rather a robot accessory than a robot description. What would be a typical use case where it is convenient to load the camera in itself? (We could add it as an example too.)

@kevinzakka
Copy link
Contributor Author

kevinzakka commented Apr 10, 2024

As of right now, this camera is purely for making aesthetic sims (e.g. in the context of creating digital twins). I'm going to send in a PR in the near future that would add MuJoCo cameras to the XML with intrinsics that match the specs of the real camera. We can leave this PR on hold until the corresponding commit in Menagerie lands, at which point this camera becomes useful beyond just pretty aesthetics.

@stephane-caron stephane-caron marked this pull request as draft April 22, 2024 12:26
@stephane-caron
Copy link
Member

OK, sounds good 👍 I've converted the PR to draft to put it on hold. Feel free to convert it back when it is ready.

@kevinzakka kevinzakka closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants