refactor(telegram): derive STALE_THROTTLE_MS from TRANSIENT_RETRY_DELAY_MS

[robster7674]

Summary

Addresses greptile style nit from PR #40: STALE_THROTTLE_MS is now expressed as TRANSIENT_RETRY_DELAY_MS + 10_000L rather than a bare magic constant. This makes the invariant (STALE_THROTTLE_MS > TRANSIENT_RETRY_DELAY_MS) self-enforcing — changing either constant cannot silently break the relationship.

No behavioral change; value remains 70 000 ms.

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

Purely cosmetic/constant-derivation refactor: STALE_THROTTLE_MS is no longer a bare magic number but is expressed as TRANSIENT_RETRY_DELAY_MS + 10_000L, keeping the > invariant self-enforcing. The redundant usage-site comment that restated the same invariant in prose is removed. No runtime behaviour changes.

• STALE_THROTTLE_MS value stays at 70 000 ms; only its definition form changes.
• Three lines of now-redundant usage-site commentary are cleanly removed.

Confidence Score: 5/5

Safe to merge — the computed value of STALE_THROTTLE_MS is identical to the removed literal, and the only other change is deleting a now-redundant comment.

The change is a single constant re-expression (60 000 + 10 000 = 70 000) and a comment deletion. Kotlin permits compile-time arithmetic on const vals, so there is no runtime difference whatsoever.

No files require special attention.

Important Files Changed

Filename	Overview
Common/src/main/java/tk/glucodata/TelegramStaleCheckWork.kt	STALE_THROTTLE_MS is now derived as TRANSIENT_RETRY_DELAY_MS + 10_000L (still 70 000 ms); redundant usage-site comment is removed. No logic change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["TRANSIENT_RETRY_DELAY_MS = 60 000 ms"] --> B["STALE_THROTTLE_MS = TRANSIENT_RETRY_DELAY_MS + 10 000 ms\n= 70 000 ms"]
    B --> C{lastStaleMs > 0\nAND now - lastStaleMs < STALE_THROTTLE_MS?}
    C -- Yes --> D["Skip recipient\n(throttled)"]
    C -- No --> E["Send stale/missed message"]
    E --> F{Result}
    F -- true --> G["Record staleAt, reschedule if STALE"]
    F -- false --> H["Clear recipient state"]
    F -- null --> I["Retry after TRANSIENT_RETRY_DELAY_MS (60 s)"]

Loading

_{Reviews (2): Last reviewed commit: "refactor(telegram): drop redundant invar..." | Re-trigger Greptile}