Skip to content

refactor(telegram): derive STALE_THROTTLE_MS from TRANSIENT_RETRY_DELAY_MS #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robster7674 merged 2 commits into from
Jun 9, 2026
Merged

refactor(telegram): derive STALE_THROTTLE_MS from TRANSIENT_RETRY_DELAY_MS #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f55fc
refactor(telegram): derive STALE_THROTTLE_MS from TRANSIENT_RETRY_DEL…
Jun 9, 2026
9dd5f03
refactor(telegram): drop redundant invariant comment at throttle check
Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Common/src/main/java/tk/glucodata/TelegramStaleCheckWork.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ object TelegramStaleCheckWork {

private const val STALE_PREFIX = "telegram_stale_check:"
private const val TRANSIENT_RETRY_DELAY_MS = 60_000L
// Must exceed TRANSIENT_RETRY_DELAY_MS: a recipient that just posted STALE is
// throttled on the 60 s retry cycle but re-evaluated when the missed-threshold
// timer fires (which can be minutes later).
private const val STALE_THROTTLE_MS = 70_000L
// Derived from TRANSIENT_RETRY_DELAY_MS to keep the invariant self-enforcing:
// a recipient that just posted STALE is skipped on the 60 s retry cycle but
// re-evaluated when the missed-threshold timer fires later.
private const val STALE_THROTTLE_MS = TRANSIENT_RETRY_DELAY_MS + 10_000L

fun schedule(context: Context, destinationId: String, delayMs: Long) {
val key = STALE_PREFIX + destinationId
Expand Down Expand Up @@ -83,9 +83,6 @@ object TelegramStaleCheckWork {
else -> continue
}
val lastStaleMs = destination.lastStaleAtMsByRecipient[recipient] ?: 0L
// STALE_THROTTLE_MS > TRANSIENT_RETRY_DELAY_MS: a recipient that just
// succeeded is skipped on the 60 s retry cycle but re-evaluated when
// the missed-threshold timer fires later.
if (lastStaleMs > 0L && now - lastStaleMs < STALE_THROTTLE_MS) continue
val hasActiveBubble = (destination.lastMessageIdByRecipient[recipient] ?: 0L) > 0L
if (!hasActiveBubble) continue
Expand Down
Loading