fix: be compatible with older installation manifest files #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doudou
force-pushed
the
load_old_installation_manifest
branch
from
1276cf8 to
b0902dc
Compare
Contributor
|
Can you add a test case? Also, do you know what happened to the test suite? |
Member
Author
Sure, will do. In a bit of a rush, so I thought I'll do it later. rexml gem update ... pushed a fix. Empty files are rejected now. |
doudou
force-pushed
the
load_old_installation_manifest
branch
2 times, most recently
from
42205c3 to
b04f576
Compare
Newer rexml versions started rejecting empty files as invalid XML
doudou
force-pushed
the
load_old_installation_manifest
branch
from
b04f576 to
f8b9156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.