Skip to content

Conversation

@saikishor
Copy link
Member

Add realtime priority inheritance mutexes for using within the realtime loops

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 30 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (246e57e) to head (8b0bded).

Files with missing lines Patch % Lines
include/realtime_tools/mutex.hpp 46.42% 19 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   73.16%   70.12%   -3.05%     
==========================================
  Files           7        8       +1     
  Lines         436      492      +56     
  Branches       72       84      +12     
==========================================
+ Hits          319      345      +26     
- Misses         73       92      +19     
- Partials       44       55      +11     
Flag Coverage Δ
unittests 70.12% <46.42%> (-3.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/mutex.hpp 46.42% <46.42%> (ø)

@saikishor saikishor requested a review from Maverobot November 20, 2024 23:50
@saikishor saikishor force-pushed the add/realtime/mutexes branch from c5250a1 to 91cce17 Compare November 25, 2024 06:09
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pthread is not available on windows

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if CI is happy so am I

@christophfroehlich christophfroehlich merged commit 74d6a83 into ros-controls:master Dec 21, 2024
18 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport humble

@mergify
Copy link

mergify bot commented Dec 21, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 21, 2024
---------

Co-authored-by: atzaros <[email protected]>
(cherry picked from commit 74d6a83)
christophfroehlich pushed a commit that referenced this pull request Dec 21, 2024
Add realtime priority inheritance mutexes (#197)

---------

Co-authored-by: atzaros <[email protected]>
(cherry picked from commit 74d6a83)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants