Add controller node options args to be able to set controller specific node arguments

[saikishor]

A different approach of #1712

    robot_controller_spawner = Node(
        package="controller_manager",
        executable="spawner",
        arguments=["diffbot_base_controller", "--param-file", controller_config, "--controller-ros-args", '--ros-args -r /diffbot_base_controller/cmd_vel:=/cmd_vel'],
    )

Fixes: #1711
Fixes: #1714

[codecov]

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.70%. Comparing base (7374c43) to head (32583ca).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	80.00%	1 Missing and 2 partials ⚠️
controller_manager/controller_manager/spawner.py	50.00%	1 Missing and 1 partial ⚠️
...r_manager/test/test_controller/test_controller.cpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage   87.73%   87.70%   -0.04%     
==========================================
  Files         122      122              
  Lines       13010    13043      +33     
  Branches     1165     1170       +5     
==========================================
+ Hits        11414    11439      +25     
- Misses       1165     1169       +4     
- Partials      431      435       +4     

Flag	Coverage Δ
unittests	87.70% <78.78%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...r_manager/test/test_controller/test_controller.hpp	100.00% <ø> (ø)
controller_manager/test/test_spawner_unspawner.cpp	96.56% <100.00%> (+0.08%)	⬆️
controller_manager/controller_manager/spawner.py	72.38% <50.00%> (-0.69%)	⬇️
...r_manager/test/test_controller/test_controller.cpp	92.15% <50.00%> (-3.59%)	⬇️
controller_manager/src/controller_manager.cpp	76.35% <80.00%> (-0.04%)	⬇️

[mergify]

This pull request is in conflict. Could you fix it @saikishor?

[christophfroehlich]

I like, but needs some tests for it and advertisement in the release notes. We could also think of deprecating the "old way" #1712

Tested successfully with ros-controls/ros2_control_demos#577

[saikishor]

Fix for compilation

[saikishor]

I like, but needs some tests for it and advertisement in the release notes. We could also think of deprecating the "old way" #1712

Tested successfully with ros-controls/ros2_control_demos#577

@christophfroehlich I've added the tests for this case and the release_notes.

Thank you!

[christophfroehlich]

thx

[mergify]

This pull request is in conflict. Could you fix it @saikishor?

[mergify]

This pull request is in conflict. Could you fix it @saikishor?

[saikishor]

@bmagyar the CI seems to be happy

[christophfroehlich]

I'll add example_interfaces to the debian image used for the CI.

[saikishor]

I'll add example_interfaces to the debian image used for the CI.

Thank you @christophfroehlich

[christophfroehlich]

LGTM (debian CI is happy now, too).

[mergify]

This pull request is in conflict. Could you fix it @saikishor?

[bmagyar]

Is this still needed?

[saikishor]

Is this still needed?

@bmagyar yes, we will still need it
Right now, we can only override from main one with a hack. This is good to have, then we can relay topic and do things at runtime with spawner, rather than readjusting the ros2_control_node and relaunching