Update CPU affinity parameter to be able to set multiple CPUs #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
christophfroehlich,
destogl,
erickisos,
fmauch,
mcbed and
peterdavidfagan
Member
Author
|
@firesurfer Can you take a look at the changes? |
firesurfer
reviewed
Dec 5, 2024
firesurfer
approved these changes
Dec 5, 2024
Contributor
firesurfer
left a comment
firesurfer
left a comment
There was a problem hiding this comment.
Apart from the missing documentation update this looks fine!
firesurfer
approved these changes
Dec 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1915 +/- ##
==========================================
- Coverage 87.83% 87.75% -0.08%
==========================================
Files 122 122
Lines 12926 12939 +13
Branches 1153 1155 +2
==========================================
+ Hits 11353 11355 +2
- Misses 1148 1158 +10
- Partials 425 426 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Should we update that in the release notes?
Member
Author
Yes! You are right. I forgot that part 😅😅 |
bmagyar
approved these changes
Dec 7, 2024
christophfroehlich
added
the
backport-humble
Member
|
@Mergifyio backport humble |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
(cherry picked from commit 0ef99fe) # Conflicts: # controller_manager/src/ros2_control_node.cpp # doc/release_notes.rst
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the strategy on handling CPU affinity. The changes here allow to use multiple CPUs instead of a single one as in previous implementation
Similar approach as #1898