Skip to content

[CLI] print update_rate and is_async on verbose #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saikishor
Copy link
Member

This was introduced by error in my previous PR: #2102

With master

$ ros2 control list_controllers 
forward_position_controller forward_command_controller/ForwardCommandController  active
	update_rate: 10 Hz
	is_async: False
position_controller         passthrough_controller/PassthroughController         active
	update_rate: 10 Hz
	is_async: False
joint2_position_controller  passthrough_controller/PassthroughController         active
	update_rate: 10 Hz
	is_async: False
joint1_position_controller  passthrough_controller/PassthroughController         active
	update_rate: 10 Hz
	is_async: False
joint_state_broadcaster     joint_state_broadcaster/JointStateBroadcaster        active
	update_rate: 10 Hz
	is_async: False

With fix proposed in this PR:

$ ros2 control list_controllers 
forward_position_controller forward_command_controller/ForwardCommandController  active
position_controller         passthrough_controller/PassthroughController         active
joint2_position_controller  passthrough_controller/PassthroughController         active
joint1_position_controller  passthrough_controller/PassthroughController         active
joint_state_broadcaster     joint_state_broadcaster/JointStateBroadcaster        active

Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.26%. Comparing base (d7b0af6) to head (9374846).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage   89.24%   89.26%   +0.01%     
==========================================
  Files         139      139              
  Lines       15504    15504              
  Branches     1318     1318              
==========================================
+ Hits        13837    13840       +3     
+ Misses       1162     1160       -2     
+ Partials      505      504       -1     
Flag Coverage Δ
unittests 89.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor merged commit 90d1c59 into ros-controls:master Mar 23, 2025
26 checks passed
@saikishor saikishor deleted the fix/cli/list_controllers branch March 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants