-
Notifications
You must be signed in to change notification settings - Fork 337
Use ros2_control_cmake #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ros2_control_cmake #2134
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2134 +/- ##
==========================================
- Coverage 89.30% 89.29% -0.02%
==========================================
Files 139 139
Lines 15502 15502
Branches 1318 1318
==========================================
- Hits 13844 13842 -2
- Misses 1155 1156 +1
- Partials 503 504 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good to me.
@christophfroehlich what do you think of waiting for a tag with the current master before introducing this? Or do you prefer to have this in all masters already?
why do you want to tag it before? it should not change much |
I don't have any reason, just a question. Anyway, the changes look great |
No description provided.