Skip to content

Use ros2_control_cmake #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Use ros2_control_cmake #2134

merged 3 commits into from
Mar 28, 2025

Conversation

christophfroehlich
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (90d1c59) to head (0dda420).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
- Coverage   89.30%   89.29%   -0.02%     
==========================================
  Files         139      139              
  Lines       15502    15502              
  Branches     1318     1318              
==========================================
- Hits        13844    13842       -2     
- Misses       1155     1156       +1     
- Partials      503      504       +1     
Flag Coverage Δ
unittests 89.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me.

@christophfroehlich what do you think of waiting for a tag with the current master before introducing this? Or do you prefer to have this in all masters already?

@christophfroehlich
Copy link
Contributor Author

why do you want to tag it before? it should not change much

@saikishor
Copy link
Member

why do you want to tag it before? it should not change much

I don't have any reason, just a question. Anyway, the changes look great

@christophfroehlich christophfroehlich merged commit 0d7bbfa into master Mar 28, 2025
22 of 25 checks passed
@christophfroehlich christophfroehlich deleted the cmake branch March 28, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants