Skip to content

[RM] Add error handling for missing plugin tags in URDF parsing #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025

Conversation

Mehul0x
Copy link
Contributor

@Mehul0x Mehul0x commented Mar 26, 2025

Added a try-catch block statement to check the validity of type_it in hardware interface parser. It returns an error signifying the missing plugin in either hardware or transmission element

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (0d7bbfa) to head (a602514).

Files with missing lines Patch % Lines
hardware_interface/src/component_parser.cpp 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
- Coverage   89.25%   89.23%   -0.03%     
==========================================
  Files         139      139              
  Lines       15504    15508       +4     
  Branches     1318     1320       +2     
==========================================
  Hits        13838    13838              
- Misses       1161     1163       +2     
- Partials      505      507       +2     
Flag Coverage Δ
unittests 89.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/component_parser.cpp 93.83% <0.00%> (-0.90%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor linked an issue Mar 27, 2025 that may be closed by this pull request
8 tasks
@saikishor saikishor changed the title [Fix] Add error handling for missing plugin tags in URDF parsing #issue-2130 [Fix] Add error handling for missing plugin tags in URDF parsing Mar 27, 2025
@saikishor saikishor changed the title [Fix] Add error handling for missing plugin tags in URDF parsing [RM] Add error handling for missing plugin tags in URDF parsing Mar 27, 2025
@Mehul0x Mehul0x requested a review from saikishor March 28, 2025 04:21
saikishor
saikishor previously approved these changes Mar 28, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich linked an issue Mar 28, 2025 that may be closed by this pull request
@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Mar 28, 2025
@christophfroehlich christophfroehlich dismissed stale reviews from saikishor and themself via 5316a3e March 28, 2025 10:15
@christophfroehlich christophfroehlich enabled auto-merge (squash) March 28, 2025 12:24
@christophfroehlich christophfroehlich merged commit c4aca5f into ros-controls:master Mar 28, 2025
20 of 24 checks passed
mergify bot pushed a commit that referenced this pull request Mar 28, 2025
)

(cherry picked from commit c4aca5f)

# Conflicts:
#	hardware_interface/src/component_parser.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
3 participants