-
Notifications
You must be signed in to change notification settings - Fork 337
[RM] Add error handling for missing plugin
tags in URDF parsing
#2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 89.25% 89.23% -0.03%
==========================================
Files 139 139
Lines 15504 15508 +4
Branches 1318 1320 +2
==========================================
Hits 13838 13838
- Misses 1161 1163 +2
- Partials 505 507 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
requested changes
Mar 26, 2025
8 tasks
plugin
tags in URDF parsing
saikishor
reviewed
Mar 28, 2025
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
previously approved these changes
Mar 28, 2025
christophfroehlich
previously approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
5316a3e
christophfroehlich
approved these changes
Mar 28, 2025
saikishor
approved these changes
Mar 28, 2025
c4aca5f
into
ros-controls:master
20 of 24 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
) (cherry picked from commit c4aca5f) # Conflicts: # hardware_interface/src/component_parser.cpp
christophfroehlich
pushed a commit
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a try-catch block statement to check the validity of type_it in hardware interface parser. It returns an error signifying the missing plugin in either hardware or transmission element