Add tests for multiple controller ros args #2155
Conversation
github-actions
bot
requested review from
ARK3r,
arne48,
bmagyar,
DasRoteSkelett,
destogl,
livanov93 and
Raivias
| "ctrl_2 -c test_controller_manager --controller-ros-args '-r /ctrl_2/set_bool:=/set_bool'"), | ||
| call_spawner("ctrl_2 -c test_controller_manager --controller-ros-args '-r " | ||
| "/ctrl_2/set_bool:=/set_bool -p run_cycle:=20' --controller-ros-args '-r " | ||
| "/ctrl_1/set_value:=/set_value'"), |
There was a problem hiding this comment.
you want to check for the /set_value as well?
There was a problem hiding this comment.
Not really. There is nothing related. This is just to test that it doesn't break at spawner level
There was a problem hiding this comment.
I can move the parameter part to the second part. May be that's more robust way
There was a problem hiding this comment.
I see 3 --ros-args, two remap rules and one parameter. Why just don't check for all the three of them?
There was a problem hiding this comment.
Because the second remapping doesn't exist. I just added casually. May be I can remove it
There was a problem hiding this comment.
ok sorry, I haven't checked that carefully. If we want to support space-separated rules with a single --controller-ros-args, we should somewhen also test it.
christophfroehlich
merged commit 7fba025
into
ros-controls:master
christophfroehlich
deleted the
add/tests/spawner/multi_controller_ros_args
branch
Added tests for multiple
--controller-ros-argsand also test parsing params and also check that we are able to parse the parameters in the same way