Skip to content

Bump version of pre-commit hooks (backport #2156) #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 1, 2025

This pull request contains auto-updated files of the pre-commit config. @ros-controls/ros2-maintainers please run the pre-commit workflow manually on the branch auto-update- before merging.


This is an automatic backport of pull request #2156 done by Mergify.

@mergify mergify bot added the conflicts label Apr 1, 2025
Copy link
Contributor Author

mergify bot commented Apr 1, 2025

Cherry-pick of 119d08c has failed:

On branch mergify/bp/humble/pr-2156
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 119d08c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .pre-commit-config.yaml
	modified:   controller_interface/test/test_force_torque_sensor.cpp
	modified:   controller_interface/test/test_imu_sensor.cpp
	modified:   controller_interface/test/test_pose_sensor.cpp
	modified:   controller_interface/test/test_semantic_component_interface.cpp
	modified:   controller_manager/test/test_hardware_spawner.cpp
	modified:   controller_manager/test/test_spawner_unspawner.cpp
	modified:   hardware_interface/src/component_parser.cpp
	modified:   hardware_interface/test/test_component_interfaces.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   controller_interface/src/chainable_controller_interface.cpp
	both modified:   controller_interface/test/test_chainable_controller_interface.hpp
	deleted by us:   controller_interface/test/test_led_rgb_device.cpp
	deleted by us:   controller_interface/test/test_semantic_component_command_interface.cpp
	both modified:   controller_manager/src/controller_manager.cpp
	both modified:   controller_manager/test/test_chainable_controller/test_chainable_controller.cpp
	deleted by us:   controller_manager/test/test_controller_manager_hardware_error_handling.cpp
	both modified:   controller_manager/test/test_hardware_management_srvs.cpp
	both modified:   hardware_interface/include/hardware_interface/actuator_interface.hpp
	both modified:   hardware_interface/include/hardware_interface/sensor_interface.hpp
	both modified:   hardware_interface/include/hardware_interface/system_interface.hpp
	both modified:   hardware_interface/src/actuator.cpp
	both modified:   hardware_interface/src/sensor.cpp
	both modified:   hardware_interface/src/system.cpp
	deleted by us:   hardware_interface/test/test_hardware_components/test_imu_sensor.cpp
	both modified:   hardware_interface/test/test_hardware_components/test_single_joint_actuator.cpp
	both modified:   hardware_interface/test/test_hardware_components/test_system_with_command_modes.cpp
	both modified:   hardware_interface/test/test_hardware_components/test_two_joint_system.cpp
	both modified:   hardware_interface_testing/test/test_components/test_actuator.cpp
	deleted by us:   hardware_interface_testing/test/test_components/test_actuator_exclusive_interfaces.cpp
	both modified:   hardware_interface_testing/test/test_components/test_sensor.cpp
	both modified:   hardware_interface_testing/test/test_components/test_system.cpp
	both modified:   hardware_interface_testing/test/test_resource_manager.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich christophfroehlich force-pushed the mergify/bp/humble/pr-2156 branch from 3b2c1d6 to 70509c7 Compare April 1, 2025 18:43
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 86.93694% with 29 lines in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (1db1d2d) to head (70509c7).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
hardware_interface/src/actuator.cpp 75.00% 6 Missing ⚠️
hardware_interface/src/sensor.cpp 75.00% 6 Missing ⚠️
hardware_interface/src/system.cpp 75.00% 6 Missing ⚠️
...hardware_components/test_single_joint_actuator.cpp 0.00% 6 Missing ⚠️
...terface/test/test_semantic_component_interface.cpp 50.00% 0 Missing and 2 partials ⚠️
...roller_interface/test/test_force_torque_sensor.cpp 50.00% 0 Missing and 1 partial ⚠️
controller_interface/test/test_imu_sensor.cpp 50.00% 0 Missing and 1 partial ⚠️
controller_interface/test/test_pose_sensor.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2157      +/-   ##
==========================================
+ Coverage   63.56%   63.69%   +0.13%     
==========================================
  Files         112      112              
  Lines       12852    12933      +81     
  Branches     8666     8738      +72     
==========================================
+ Hits         8169     8238      +69     
- Misses        792      804      +12     
  Partials     3891     3891              
Flag Coverage Δ
unittests 63.69% <86.93%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/test/test_chainable_controller_interface.hpp 87.80% <100.00%> (+0.30%) ⬆️
controller_manager/src/controller_manager.cpp 66.98% <100.00%> (ø)
...chainable_controller/test_chainable_controller.cpp 76.71% <100.00%> (+0.32%) ⬆️
...ler_manager/test/test_hardware_management_srvs.cpp 88.46% <100.00%> (+0.22%) ⬆️
controller_manager/test/test_hardware_spawner.cpp 78.99% <100.00%> (+0.17%) ⬆️
controller_manager/test/test_spawner_unspawner.cpp 52.06% <100.00%> (+0.07%) ⬆️
.../include/hardware_interface/actuator_interface.hpp 100.00% <100.00%> (ø)
...ce/include/hardware_interface/sensor_interface.hpp 100.00% <100.00%> (ø)
...ce/include/hardware_interface/system_interface.hpp 100.00% <100.00%> (ø)
hardware_interface/src/component_parser.cpp 90.37% <100.00%> (+0.04%) ⬆️
... and 15 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 3db79b9 into humble Apr 1, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-2156 branch April 1, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant