Skip to content

Change to ament_add_gmock in joint_limits #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

saikishor
Copy link
Member

#2162 introduced some changes that make it fail to build in Humble

@saikishor saikishor marked this pull request as ready for review April 4, 2025 08:28
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use add_rostest_with_parameters_gmock of ament_cmake_gmock instead?

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fast fix!

@christophfroehlich christophfroehlich merged commit 25be71d into master Apr 4, 2025
19 of 25 checks passed
@christophfroehlich christophfroehlich deleted the fix/humble/compatibility branch April 4, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants