Split controller switch test

[ashwinsnambiar]

Closes #521

I have split the existing test into two: lifecycle test for single controller and a switch_controller test with unknown or fake controller.

To send us a pull request, please:

• Fork the repository.
• Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
• Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
• Commit to your fork using clear commit messages.
• Send a pull request, answering any default questions in the pull request interface.
• Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

[ashwinsnambiar]

Could you please verify if what I have done is what was expected in the issue description? Should I do it for the rest of the tests like async_controller_lifecycle, async_controller_lifecycle_at_cm_rate etc.?

[saikishor]

Heyy @ashwinsnambiar

Can you explain the changes a bit?

All I see is that you have moved a part of the test into a different test case. Why?

The idea is to check which part of the BEST_EFFORT strictness logic is covered and add tests to cover the other parts

[ashwinsnambiar]

Hey @saikishor,

From what I understood, the BEST_EFFORT strictness logic has already been implemented.

I was just following the comment in the issue: #521 (comment).

I started out this draft PR which satisfies the first requirement of the splitting the test into lifecycle test and switching multiple controllers.

I haven't done the second part, adding a new test for activating multiple controllers when resource collision occurs.

Please let me know if I misunderstood the intent somewhere.

[ashwinsnambiar]

@saikishor, did you understand what I was trying to do?

[saikishor]

@saikishor, did you understand what I was trying to do?

Sorry I didn't get back to you on this. Yes, you are right. You are on the right direction :)