Skip to content

Print the type of joint limits being used for limit enforcement #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saikishor
Copy link
Member

Just added log for more information at the beginning. As discussed with christophfroehlich, we can later change it back to debug after few releases.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The joint limiter might break some user setups, so let's add more verbose info for the first releases!

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (65340a4) to head (a1f0e33).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
- Coverage   89.18%   89.18%   -0.01%     
==========================================
  Files         139      139              
  Lines       16096    16123      +27     
  Branches     1382     1387       +5     
==========================================
+ Hits        14356    14380      +24     
  Misses       1216     1216              
- Partials      524      527       +3     
Flag Coverage Δ
unittests 89.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 77.09% <ø> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@christophfroehlich christophfroehlich merged commit de00c17 into ros-controls:master Apr 16, 2025
25 of 26 checks passed
@christophfroehlich christophfroehlich deleted the add/joint_limiters/log branch April 16, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants