Modernize CMakeLists.txt to remove deprecated ament_target_dependencies (Fixes #2210) #2210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
harderthan,
LukasMacha97,
Maverobot,
Raivias,
rosterloh and
saikishor
saikishor
requested changes
Apr 29, 2025
There was a problem hiding this comment.
@LalitNarayanYadav Thank you for your comments. Just some minor comments, if they look good, you can commit them directly from UI
controller_manager/CMakeLists.txt
Outdated
Comment on lines
9
to
19
|
|
||
| find_package(controller_interface REQUIRED) | ||
| find_package(controller_manager_msgs REQUIRED) | ||
| find_package(diagnostic_updater REQUIRED) | ||
| find_package(hardware_interface REQUIRED) | ||
| find_package(pluginlib REQUIRED) | ||
| find_package(rclcpp REQUIRED) | ||
| find_package(realtime_tools REQUIRED) | ||
| find_package(std_msgs REQUIRED) | ||
| find_package(libstatistics_collector REQUIRED) | ||
| find_package(generate_parameter_library REQUIRED) |
There was a problem hiding this comment.
Is there a reason for this change?
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
reviewed
Apr 29, 2025
controller_manager/CMakeLists.txt
Outdated
| @@ -26,7 +26,6 @@ find_package(backward_ros REQUIRED) | |||
| foreach(Dependency IN ITEMS ${THIS_PACKAGE_INCLUDE_DEPENDS}) | |||
| find_package(${Dependency} REQUIRED) | |||
| endforeach() | |||
|
|
|||
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
reviewed
Apr 29, 2025
saikishor
requested changes
Apr 29, 2025
|
@LalitNarayanYadav Please fix the failing CI jobs. Please try to install pre-commit and fix by running the |
|
It would also be good to give the PR a meaningful title. @LalitNarayanYadav hope you don't mind me asking but how much of the original content of this PR was AI generated? |
LalitNarayanYadav
changed the title
|
☝️ @LalitNarayanYadav did this build for you locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize CMakeLists to remove
ament_target_dependencies()deprecation warningsThis PR updates the
CMakeLists.txtfile to replace deprecatedament_target_dependencies()calls with moderntarget_link_libraries()using namespaced targets, as recommended by ROS 2 on Rolling.✅ Changes
ament_target_dependencies()usages withtarget_link_libraries()and appropriate namespaced targets.📦 Benefits
Closes #2207