-
Notifications
You must be signed in to change notification settings - Fork 395
Fix concurrent spinning of the test_node #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
- Coverage 89.42% 89.35% -0.08%
==========================================
Files 151 151
Lines 17208 17194 -14
Branches 1429 1432 +3
==========================================
- Hits 15388 15363 -25
- Misses 1242 1251 +9
- Partials 578 580 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
reviewed
Oct 21, 2025
saikishor
previously approved these changes
Oct 21, 2025
saikishor
approved these changes
Oct 21, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
(cherry picked from commit 791eaa5)
mergify bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
(cherry picked from commit 791eaa5)
mergify bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
(cherry picked from commit 791eaa5)
This was referenced Oct 22, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 22, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 22, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
Triggers PR backport to ROS 2 humble.
backport-jazzy
Triggers PR backport to ROS 2 jazzy.
backport-kilted
Triggers PR backport to ROS 2 kilted.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2650