Skip to content

Conversation

@christophfroehlich
Copy link
Member

Resolves #2650

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.35%. Comparing base (9a9c8a9) to head (50f82ea).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
- Coverage   89.42%   89.35%   -0.08%     
==========================================
  Files         151      151              
  Lines       17208    17194      -14     
  Branches     1429     1432       +3     
==========================================
- Hits        15388    15363      -25     
- Misses       1242     1251       +9     
- Partials      578      580       +2     
Flag Coverage Δ
unittests 89.35% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller_manager/test/test_ros2_control_node_launch.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

saikishor
saikishor previously approved these changes Oct 21, 2025
@christophfroehlich christophfroehlich merged commit 791eaa5 into master Oct 22, 2025
17 of 18 checks passed
@christophfroehlich christophfroehlich deleted the fix/concurrent/spin branch October 22, 2025 06:46
mergify bot pushed a commit that referenced this pull request Oct 22, 2025
mergify bot pushed a commit that referenced this pull request Oct 22, 2025
mergify bot pushed a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeError: Executor is already spinning

3 participants