Deactivate the whole controller chain if one of the update results in ERROR (backport #2681) #2743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a way to deactivate the whole controller chain when one of the controllers in the chain is deactivated as a result of it returning
ERRORin the update cycle.For instance, for the following example, if the controller B fails, then it is deactivated automatically, but all the other controllers are left dangling, and they are left to track an invalid reference, this might lead to a catastrophic behaviour, this is especially true when you are tracking a
velocity,force, ortorquereferences. The idea is to bring down the whole chain along with it.graph LR; A-->B; B-->C; B-->D; D-->E;This is an automatic backport of pull request #2681 done by [Mergify](https://mergify.com).