Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 27, 2025

This PR proposes a way to deactivate the whole controller chain when one of the controllers in the chain is deactivated as a result of it returning ERROR in the update cycle.

For instance, for the following example, if the controller B fails, then it is deactivated automatically, but all the other controllers are left dangling, and they are left to track an invalid reference, this might lead to a catastrophic behaviour, this is especially true when you are tracking a velocity, force, or torque references. The idea is to bring down the whole chain along with it.

graph LR;
    A-->B;
    B-->C;
    B-->D;
    D-->E;
Loading

This is an automatic backport of pull request #2681 done by [Mergify](https://mergify.com).

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 96.85714% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.46%. Comparing base (d533db3) to head (5aa5b84).
⚠️ Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 86.15% 2 Missing and 7 partials ⚠️
...ontroller_manager/test/test_controller_manager.cpp 99.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2743      +/-   ##
==========================================
+ Coverage   89.34%   89.46%   +0.11%     
==========================================
  Files         152      152              
  Lines       17237    17568     +331     
  Branches     1427     1441      +14     
==========================================
+ Hits        15401    15717     +316     
- Misses       1269     1279      +10     
- Partials      567      572       +5     
Flag Coverage Δ
unittests 89.46% <96.85%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 97.29% <ø> (ø)
...ger/include/controller_manager/controller_spec.hpp 100.00% <ø> (ø)
...chainable_controller/test_chainable_controller.cpp 87.91% <100.00%> (ø)
...chainable_controller/test_chainable_controller.hpp 100.00% <ø> (ø)
...ontroller_manager/test/test_controller_manager.cpp 96.22% <99.29%> (+0.88%) ⬆️
controller_manager/src/controller_manager.cpp 76.88% <86.15%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 2f777ff into jazzy Oct 27, 2025
14 of 15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-2681 branch October 27, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants