[ForwardCommandController] Fix the duplicate command interface types when reconfiguring the controller (backport #1568)#1569
Merged
christophfroehlich merged 2 commits intohumblefrom Mar 4, 2025
Conversation
Member
|
@saikishor actually, I think that the last assertion of the test the test itself is written badly, because it calls on_configure again from configured state. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1569 +/- ##
=======================================
Coverage 66.95% 66.96%
=======================================
Files 115 115
Lines 13571 13575 +4
Branches 8397 8401 +4
=======================================
+ Hits 9087 9090 +3
+ Misses 1423 1415 -8
- Partials 3061 3070 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we reconfigure the controller now, it simply appends and creates duplicates. Found the issue with : ros-controls/ros2_control#2090
This is an automatic backport of pull request #1568 done by Mergify.