Deprecate publish_dynamic_joint_states parameter in joint_state_broadcaster #2107
+33
−359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caster - Change default value from true to false - Add deprecation warning in on_configure when parameter is set to true - Remove dynamic joint state assertions from tests
github-actions
bot
requested review from
MarqRazz,
aprotyas,
fmauch,
mhubii and
saikishor
bmagyar
force-pushed
the
deprecate-dyn-joint-states
branch
from
f74877c to
abf2c5d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
- Coverage 84.79% 84.48% -0.31%
==========================================
Files 151 151
Lines 14607 14518 -89
Branches 1266 1263 -3
==========================================
- Hits 12386 12266 -120
- Misses 1763 1794 +31
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
requested changes
Jan 15, 2026
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Fine for me, except..
Comment on lines
+31
to
+35
| For publishing non-standard interfaces, consider using alternatives: | ||
|
|
||
| * ``state_interfaces_broadcaster`` for broadcasting arbitrary state interfaces | ||
| * ``gpio_command_controller`` for GPIO and custom hardware interfaces | ||
| * `pal_statistics <https://github.com/pal-robotics/pal_statistics>`_ for flexible runtime statistics publishing |
Member
There was a problem hiding this comment.
This should go into the migration notes instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second step of #2044
Only meant for rolling, not to be backported.