Remappings in Bus Configuration YAML #352
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the device container
load_componentmethod, the node optionuse_global_argumentsis disabled.ros2_canopen/canopen_core/src/device_container.cpp
Line 50 in 52327f9
Therefore, any remappings passed to the
device_containernode will not modify any loaded component. For example, if trying to hide thenmt_statetopic published by thecanopen_proxy_driver, the following modification to the launch file would not work:Since the goal of disabling the global argument option is to keep all loaded devices independent, there should be a way to remap topics through the bus configuration file.
With these changes, a
remappingsentry can be added to each device in the configuration file, such that they all have their own remapped topics defined. For example, if we wanted to hide therpdotopic on one proxy device andtpdoon another, we could set each independently: