Patch lely_core_libraries SupportedObjects HEX support #388
Conversation
|
Is this being proposed also upstream? |
|
Not currently. Would it be best proposed there? |
|
Disclaimer: I'm not the maintainer here, only active user and observer. IMHO out-of-tree patches should only be stop-gap measures while either upstream patch is being reviewed -or- some kind of disagreement or lack of support happens again upstream. So I suggest/encourage you to also propose this patch on lely's gitlab. As it may take some time for this to be accepted, including here temporarily the patch would do the job in the meantime. When it gets upstreamed, another PR here should upgrade lely git hash to a newer one and remove the temporarily applied out-of-tree patch. |
|
Seems a MR already exists: That's nice! |
|
Great find. I'll engage on that MR to see if they'd want to add the linting change as well to be the same as this. |
|
The change has now been added to that MR (https://gitlab.com/lely_industries/lely-core/-/merge_requests/149). Until that moves forward I would be keen to have this as a patch in this repo. |
| UPDATE_COMMAND | ||
| COMMAND git reset --hard | ||
| COMMAND git apply --whitespace=fix --reject ${CMAKE_CURRENT_SOURCE_DIR}/patches/0001-Fix-dcf-tools.patch | ||
| COMMAND git apply --whitespace=fix --reject ${CMAKE_CURRENT_SOURCE_DIR}/patches/0002-Allow-base16-values-for-SupportedObjects.patch |
There was a problem hiding this comment.
I would add a comment above with the lely MR link. That way it's more clear when this patch can be cleaned up again.
3 participants
Some suppliers provide EDS files with HEX values for the SupportedObjects field.
This patch adds support for this.