Cleanup Boost dependencies #399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, can somebody review this PR? |
I'm trying to remove the libboost-all-dev from my robot image. I notices there is an exec_depend from `ros2_canopen` to libboost-all-dev. This is not needed for running the application, only for compiling. So I've tried to look at all the boost dependencies and categorized them properly. canopen_402_driver: - uses the headers of boost container and numeric which are part of libboost-all-dev canopen_base_driver: - doesn't depend on boost canopen_core: - boost thread requires linking to libboost-thread and the headers from libboost-all-dev - it uses the headers of boost lockfree and optional which are part of libboost-dev
Rayman
force-pushed
the
refactor/boost-dependencies
branch
from
be213a4 to
97a2359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to remove the libboost-all-dev from my robot image. I notices there is an exec_depend from
ros2_canopento libboost-all-dev. This is not needed for running the application, only for compiling. So I've tried to look at all the boost dependencies and categorized them properly.canopen_402_driver:
canopen_base_driver:
canopen_core: