Add MoveIt Servo Tutorial #688
Conversation
tahsinkose
force-pushed
the
tahsin/add-moveit-servo-tutorial
branch
from
e365194 to
d0913a8
Compare
|
@RobertWilbrandt @fmauch could you please have a look at this PR? |
AndyZe
left a comment
AndyZe
left a comment
There was a problem hiding this comment.
It would have been very nice to have this a few years ago. Personally I'd still like to see it merged after the changes get applied. I guess most of the community's efforts go towards ROS2 now, for better or worse...
ur5_moveit_tutorials/CMakeLists.txt
Outdated
| catkin_package( | ||
| ) | ||
| include_directories( | ||
| ) |
There was a problem hiding this comment.
| catkin_package( | |
| ) | |
| include_directories( | |
| ) | |
| catkin_package() |
| <!-- Load and start the controllers listed in the 'controllers' arg. --> | ||
| <node name="ros_control_controller_spawner" pkg="controller_manager" type="spawner" | ||
| args="$(arg controllers)" output="screen" respawn="false" /> | ||
| <group unless="$(eval arg('controllers') == '')"> |
There was a problem hiding this comment.
I don't think there's any reason for group if there's just one node in the group? Suggest reverting.
There was a problem hiding this comment.
I should actually have used if clause instead of this 😄
…on to work together.
…ntroller based MoveIt servo.
tahsinkose
force-pushed
the
tahsin/add-moveit-servo-tutorial
branch
from
d0913a8 to
1e65d66
Compare
|
@AndyZe addressed your review, PTAL 🙏🏼
I can migrate them to ROS 2 when I finally switch to ROS 2 🙈 |
|
@AndyZe friendly ping 🙂 |
|
I don't have merge power here |
Who should we reach then? Do you know that @AndyZe? |
|
@urfeex could you review this PR and possibly merge? |
|
I'm afraid, our resources towards ROS 1 are rather limited at the moment. |
3 participants
This PR adds two usage examples of MoveIt Servo with UR5 robot in the new
ur5_moveit_tutorialspackage