Support new image_transport API and fix deprecation warnings #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
ahcorde
reviewed
Sep 1, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
There is already a PR fixing this https://github.com/ros-perception/image_pipeline/pull/1099/files
Member
|
@ahcorde as a note - 1099 doesn't include the fixes to remove spin_some() that are in this PR |
Contributor
ahcorde
added a commit
that referenced
this pull request
Sep 16, 2025
Related with this comment #1114 (comment) Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1113 by adapting to new
image_transportAPIs and also addresses other deprecation warnings from ros2/rclcpp#2848Supersedes #1099