Fix duplicate symbol error for collect_metrics flag in offline_node (Issue #80)
#84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a compilation issue caused by duplicate definition of the
collect_metricsgflags flag.Issue
as issue #80 said, running
cartographer_rosfails with the following error:This occurred because
src/offline_node.cppwas being linked into both thecartographer_rosshared library and thecartographer_offline_nodeexecutable, causing a symbol conflict.Changes Made
src/offline_node.cppfrom the shared library source list to avoid duplicate symbol definitions.src/offline_node.cppto thecartographer_offline_nodeexecutable target.urdfdependency to the offline node target.PRE_JAZZY_SERIALIZED_BAG_MSG_FIELD_NAMEto maintain consistency.Verification