Update type_support.py to use new message abstract base classes
#1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Converted to draft for the moment since ros2/rosidl_python#241 should come first and might require some changes here. |
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: brennanmk <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
…ros2#1478) Closes ros2#1473 Signed-off-by: Brad Martin <[email protected]> Co-authored-by: Brad Martin <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Per rclpy:1123 If two seperate client server actions are running in seperate executors the future given to the ActionClient will never complete due to a race condition This fixes the calls to rcl handles potentially leading to deadlock scenarios by adding locks to there references Co-authored-by: Aditya Agarwal <[email protected]> Co-authored-by: Jonathan Blixt <[email protected]> Signed-off-by: Jonathan Blixt <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
'param_type' is set but never used Signed-off-by: Christian Rauch <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
A recent change intended to move this logic into a lock context, but actually ended up duplicating it instead. This fixes that by removing the duplicated logic outside of the lock. It also preserves the explicit typing annotation on the future. Signed-off-by: Nathan Wiebe Neufeldt <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: yuanyuyuan <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
InvincibleRMC
force-pushed
the
use-new-message-abcs
branch
from
35e195c to
47b0c29
Compare
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
… into use-new-message-abcs
Signed-off-by: Michael Carlstrom <[email protected]>
InvincibleRMC
force-pushed
the
use-new-message-abcs
branch
from
068d8d5 to
f418f07
Compare
Contributor
Author
|
@christophebedard Should be ready for review now. Tested it locally with the |
Contributor
Author
|
@christophebedard just a reminder whenever you are free I would appreciate a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses new abstract base classes to allow automatic type inference lowering burden to start using pub/sub/server/client/actionserver/actionclient. This can be seen in how the test cases do not require the manual specification of their generic types and that can now be inferred from the msg/srv/action type automatically.
Fixes one task from this main list
ros2/ros2#1735
Is this user-facing behavior change?
The classes inside
type_support.pyare no longerprotocolsbut, actual generic classes. Users shouldn't need to change anything for this but, a user could in theory now decide to actual instantiate this class at runtime even if that doesn't really serve a point.Did you use Generative AI?
Additional Information