3di | Making and reviewing a pull request#6892
Conversation
kscottz
left a comment
kscottz
left a comment
There was a problem hiding this comment.
This is better than we have so I'll approve it but I made a couple of minor suggestions.
…ng-a-PR.rst Co-authored-by: Katherine Scott <katherineAScott@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ood-3di/ros2_documentation into making-reviewing-a-pr
|
@kscottz (cc @tfoote) There are 2 types of issues which keep popping up in our docs builds for the 3di staff:
Could you advise on these? |
|
Just a heads up, I'm at a giant trade show this week and I'm not sure how much time I'll have to look into this. Perhaps @ahcorde can kindly take a look. I did get a brief chance to look at the first error on Thursday. I couldn't track down where it was introduced but it looks like it may be some sort of intermittent request failure due to bot checking. The AI suggests replacing the offending line with The second issue seems to be warning on a deprecated versions of ROS that just cropped up. I don't believe anything was back-ported that far which seems odd. I poked around a little bit and the offending file numbers don't line up. There is a reference to |
|
Heads up @ottojo @ahcorde @christophebedard. Regarding the first set of warnings mentioned above could this PR have introduced the error? I was grepping around and saw it in the release notes and it seemed like the potential culprit. @keithkirkwood-3di I just put in #6907 that should fix the second set of warnings. It seems like it removed the "reference:any" errors but the second set of warnings still remain. The PR doesn't exactly fix the problem but it removes the offending lines. |
|
@kscottz @christophebedard Hey folks - thanks for the build investigation and fixes. These have resolved my build errors. Thanks also for the great input - we've now implemented your feedback on these 2 articles, simplifying it in a few places for clarity and brevity (so as not to put off new contributors). Take a look and let us know what you think? |
3 participants
Description
Create new how-to articles for Making a pull request and Reviewing a pull request under new section Contributing to code.
These draw from several existing articles, refactoring the content and removing from the original location.
There will be an action at the end of the tickets under this issue to clean up, so that we don’t end up with any duplicates or dead ends.
Related to: #6828
Did you use Generative AI?
No
Additional Information
Documentation updates from 3di Information Solutions, agreed with Geoff and Tully.