Skip to content

Fix warning on deprecated ROS release notes. #6907

Merged
ahcorde merged 2 commits into
rollingfrom
fix-warning-on-EOLs
Jun 22, 2026
Merged

Fix warning on deprecated ROS release notes. #6907
ahcorde merged 2 commits into
rollingfrom
fix-warning-on-EOLs

Conversation

@kscottz

@kscottz kscottz commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Description

@keithkirkwood-3di at 3Di is reporting a new warning that is blocking them. I don't have a good sense of the root cause of the warning but the offending line doesn't seem like it is necessary and the warning only appears on deprecated releases so I am pretty sure it can be safely removed.

Fixes # (issue)

Did you use Generative AI?

No.

Additional Information

If this doesn't work feel free to close the PR.

@kscottz kscottz changed the title Let's see if this fixes the warning. Fix warning on deprecated ROS release notes. Jun 21, 2026
@fujitatomoya

Copy link
Copy Markdown
Collaborator

@kscottz thank for trying to address the warnings. this PR surely addresses the

the test is still failing, this is found by "reference:any" errors, which are found in #6892 (comment).

the another one is tricky though.
docs.ros.org is now behind Anubis anti-bot protection. when sphinx.ext.intersphinx tries to fetch the 7 objects.inv inventory files, the server returned an HTML "Making sure you're not a bot!" challenge page instead of a real inventory, producing 7 warnings. since Makefile builds with -W (warnings-as-errors), the build aborted.
this is an external infrastructure change (Anubis), not a docs PR.

i think it would be okay to remove those mappings, because they are not used except python. i will add the fix on this.

this is because of an external infrastructure change (Anubis), not a docs PR.

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kscottz i can only approve your fix. can you do the same for mine?

Comment thread conf.py
@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 22, 2026
@github-actions

Copy link
Copy Markdown

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/27921622522/artifacts/7780599095.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-6907/index.html in your favorite browser

@fujitatomoya

Copy link
Copy Markdown
Collaborator

now all workflows should pass.

@kscottz

kscottz commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

.@fujitatomoya thanks! Which PR do you need a review / approval on? I didn't see anything in the queue.

Is it just a matter of updating form http to https in the conf file?

@fujitatomoya

Copy link
Copy Markdown
Collaborator

ah sorry, i was just asking if my fix in this PR looks good to you.

@kscottz

kscottz commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@fujitatomoya thanks. Let me yank those files and see if we can't get CI green.

@kscottz

kscottz commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

This all looks good to me.

@christophebedard @ahcorde can you take a look?

@keithkirkwood-3di this PR should fix your CI issues. Once it is merged pull from rolling and CI should go green.

@ahcorde ahcorde merged commit 1a70bf8 into rolling Jun 22, 2026
7 checks passed
@ahcorde ahcorde deleted the fix-warning-on-EOLs branch June 22, 2026 07:13
ahcorde pushed a commit that referenced this pull request Jun 22, 2026
(cherry picked from commit 1a70bf8)

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Co-authored-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
ahcorde added a commit that referenced this pull request Jun 22, 2026
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jun 22, 2026
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jun 22, 2026
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants