Fix warning on deprecated ROS release notes. #6907
Conversation
|
@kscottz thank for trying to address the warnings. this PR surely addresses the the test is still failing, this is found by "reference:any" errors, which are found in #6892 (comment). the another one is tricky though. i think it would be okay to remove those mappings, because they are not used except python. i will add the fix on this. |
this is because of an external infrastructure change (Anubis), not a docs PR. Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
@kscottz i can only approve your fix. can you do the same for mine?
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/27921622522/artifacts/7780599095. To view the resulting site:
|
|
now all workflows should pass. |
|
.@fujitatomoya thanks! Which PR do you need a review / approval on? I didn't see anything in the queue. Is it just a matter of updating form |
|
ah sorry, i was just asking if my fix in this PR looks good to you. |
|
@fujitatomoya thanks. Let me yank those files and see if we can't get CI green. |
|
This all looks good to me. @christophebedard @ahcorde can you take a look? @keithkirkwood-3di this PR should fix your CI issues. Once it is merged pull from |
Description
@keithkirkwood-3di at 3Di is reporting a new warning that is blocking them. I don't have a good sense of the root cause of the warning but the offending line doesn't seem like it is necessary and the warning only appears on deprecated releases so I am pretty sure it can be safely removed.
Fixes # (issue)
Did you use Generative AI?
No.
Additional Information
If this doesn't work feel free to close the PR.