Open
Conversation
MH4GF
reviewed
Mar 15, 2024
| "format": "pnpm format:biome:format && pnpm format:biome:check", | ||
| "format:biome:format": "biome format --write .", | ||
| "format:biome:check": "biome check --apply ." | ||
| "lint": "biome lint .", |
Contributor
There was a problem hiding this comment.
From the user's point of view, I think biome lint is not sufficient since it does not check format files and organize imports.
I think it would be better to leave biome check as it is. What do you think?
| "format:biome:format": "biome format --write .", | ||
| "format:biome:check": "biome check --apply ." | ||
| "lint": "biome lint .", | ||
| "format": "biome check --apply ." |
Contributor
There was a problem hiding this comment.
This one looks good! Thank you 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
biome checkcommand applies bothbiome formatandbiome lint, so theformatscript is enough forbiome check --apply.https://biomejs.dev/guides/getting-started/#usage