Skip to content

Tweak scripts #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toyamarinyon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tweak scripts #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@
"setup": "corepack enable pnpm",
"build": "tsup src/index.ts --format esm,cjs --dts",
"test": "vitest",
"lint": "biome check .",
"format": "pnpm format:biome:format && pnpm format:biome:check",
"format:biome:format": "biome format --write .",
"format:biome:check": "biome check --apply ."
"lint": "biome lint .",
Copy link
Contributor

@MH4GF MH4GF Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the user's point of view, I think biome lint is not sufficient since it does not check format files and organize imports.
I think it would be better to leave biome check as it is. What do you think?

"format": "biome check --apply ."
Copy link
Contributor

@MH4GF MH4GF Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good! Thank you 😄

},
"dependencies": {
"@urql/core": ">=4.0.0",
Expand Down