Allow RPM to get signature salt for OpenPGP v6 signatures#92
Allow RPM to get signature salt for OpenPGP v6 signatures#92Jakuje wants to merge 9 commits intorpm-software-management:mainfrom
Conversation
Also updates the GH actions versions to latest ones. Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Formed the same way as the v4 ones. Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
to match the expected one Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
|
Rpm side at rpm-software-management/rpm#3848 Haven't tried with the actual test-suite, just manual verify:
|
|
Run of this branch against the rpm-software-management/rpm#3848 is here (not sure why it did not run in the pr directly): https://github.com/Jakuje/rpm-sequoia/actions/runs/15995286790/job/45117251685 |
|
Latest run in my fork with recent changes from Panu worked: https://github.com/Jakuje/rpm-sequoia/actions/runs/15998694606/job/45128059715 |
|
So this works and the Salt() interface is what I suggested in the other PR, I'm just pondering whether there is any real value in returning an error code over just returning NULL if there's no salt, ie
I've no strong opinions on this, just thinking out loud. |
|
I do not really have a preference. I slightly prefer the current approach approach (what is now in the PR) as I like the Error/Success is written in the rust way with the Result(Ok/Err) being mapped directly to |
|
Ok, in that case lets just keep it as it is 👍 |
nwalfield
left a comment
There was a problem hiding this comment.
Unfortunately, I'm not able to run the test suite using the instructions in the README. Could you help me debug the issue, please?
|
I'm closing this in favor of #93 . |
Most of the content is the same as in #91, but attempts to address the hashing issue using the new API for RPM.