Support OpenPGP v6 signature pre-salting#3848
Merged
dmnks merged 2 commits intorpm-software-management:masterfrom Jul 8, 2025
Merged
Support OpenPGP v6 signature pre-salting#3848dmnks merged 2 commits intorpm-software-management:masterfrom
dmnks merged 2 commits intorpm-software-management:masterfrom
Conversation
Jakuje
added a commit
to Jakuje/rpm-sequoia
that referenced
this pull request
Jul 1, 2025
Collaborator
|
I also need to support this in the "legacy" pgp code. |
Member
Author
|
The bundle-id update has a proper PR of its own now as that can be merged without having to wait for a new rpm-sequoia: #3855 |
Member
Author
|
(rebased on top of #3855) |
Member
Author
|
Updated to require rpm-sequoia >= 1.9.0 now that we know the version (rpm-software-management/rpm-sequoia#97) Of course this wont pass until that version is available to us in the CI, so can't undraft yet. |
Member
Author
Contributor
|
New rpm-sequoia is on the way to Fedora: https://src.fedoraproject.org/rpms/rust-rpm-sequoia/pull-request/4 |
OpenPGP v6 signature salt is a random per-signature thing that we need to feed into the digest before the actual data. For that we need rpm-sequoia support, the first version to have it is 1.9.0. The tests for this are already written, just need to be adjusted a bit and uncommented, so do that. Kudos to Jakub for covering this part via PR rpm-software-management#3844 (squashed into this commit)! Co-authored-by: Jakub Jelen <jjelen@redhat.com> Fixes: rpm-software-management#3846
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Contributor
|
I've merged the related tests from #3844 into the original commit here. The sha3 test is not directly related so I've kept that one as a separate commit. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the necessary rpm-side bits to support v6 signature verification with the aid of rpm-sequoia + rpm-software-management/rpm-sequoia#92
Draft for now as there's no rpm-sequoia release that we can use in CI.