Fix/trunk wasm start#74
Conversation
syzer
force-pushed
the
fix/trunk-wasm-start
branch
from
8c5e823 to
7550753
Compare
|
The typing and structure selection not works well on iPhone sadly. I'll try to fix it, this will be a good exercise for me ;) |
| - name: Run wasm compile checks | ||
| run: | | ||
| cargo check -p vizmat-core --target wasm32-unknown-unknown --no-default-features | ||
| cargo check -p vizmat-app --target wasm32-unknown-unknown --no-default-features | ||
|
|
There was a problem hiding this comment.
I assume wasm-pack build will build it with wasm32 target no?
There was a problem hiding this comment.
this is faster to fail invalid wasm . no need to run build if that fails
| run: cargo fmt --all -- --check | ||
|
|
||
| # Run wasm compile checks to catch web-only type mismatches. | ||
| wasm_check: |
There was a problem hiding this comment.
This is covered by deploy.yml, so I think no need to duplicate test it here?
Emm... I think that deploy test is a bit more, so I get you now. Make sense to test build for wasm here in CI.
was thinking to switching for web selectbox even .. because we have to handle events manually. |
2 participants
No description provided.