-
Notifications
You must be signed in to change notification settings - Fork 7
Fix/trunk wasm start #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
syzer
wants to merge
10
commits into
rs4rse:main
Choose a base branch
from
syzer:fix/trunk-wasm-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bcdb9a3
refactor(ui): move picker into module and add search tests
syzer f321a00
feat: add mobile picker keyboard input bridge
syzer ad4bddf
fix: place picker caret beside search text
syzer 1dc0c9f
fix: keep picker colors updated on theme switch
syzer c117d77
ci: add wasm compile checks and guard selector window retrieval
syzer fa23246
fix: enable touch drag scroll for mobile picker
syzer e59b769
fix: guard picker taps during touch scroll
syzer efd53ae
Fix bond picker visibility for file/infer modes
syzer 7550753
Fix WASM startup in Trunk
syzer 873f031
Adjust mobile canvas top offset below title
syzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,11 @@ jobs: | |
| run: | | ||
| curl https://drager.github.io/wasm-pack/installer/init.sh -sSf | bash | ||
|
|
||
| - name: Run wasm compile checks | ||
| run: | | ||
| cargo check -p vizmat-core --target wasm32-unknown-unknown --no-default-features | ||
| cargo check -p vizmat-app --target wasm32-unknown-unknown --no-default-features | ||
|
|
||
|
Comment on lines
+33
to
+37
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is faster to fail invalid wasm . no need to run build if that fails |
||
| - name: Build WASM | ||
| run: | | ||
| if [ "${{ github.ref }}" = "refs/heads/main" ]; then | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is covered by
deploy.yml, so I think no need to duplicate test it here?Emm... I think that deploy test is a bit more, so I get you now. Make sense to test build for wasm here in CI.