feat: changed accept pegin and pegout reponse status#631
Merged
gsoares85 merged 2 commits intoflyover-2.1.1from Feb 17, 2025
Merged
feat: changed accept pegin and pegout reponse status#631gsoares85 merged 2 commits intoflyover-2.1.1from
gsoares85 merged 2 commits intoflyover-2.1.1from
Conversation
gsoares85
requested review from
AndresQuijano,
Dominikkq,
Luisfc68 and
MaximStanciu8
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Luisfc68
reviewed
Feb 14, 2025
| jsonErr := rest.NewErrorResponseWithDetails("invalid request", rest.DetailsFromError(err), true) | ||
| rest.JsonErrorResponse(w, http.StatusBadRequest, jsonErr) | ||
| jsonErr := rest.NewErrorResponseWithDetails("quote not found", rest.DetailsFromError(err), true) | ||
| rest.JsonErrorResponse(w, http.StatusNotFound, jsonErr) |
Collaborator
There was a problem hiding this comment.
this will return 404 also when the quote is expired, shouldn't that scenario maintain the 400?
Contributor
There was a problem hiding this comment.
Agree to differentiate the error code
MaximStanciu8
approved these changes
Feb 17, 2025
Luisfc68
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In accept pegin and pegout case the quote where not found or expired, will return instead of 400 status a 404 status and a message of quote not found for user.