Skip to content

feat: changed accept pegin and pegout reponse status #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsoares85 merged 2 commits into from
Feb 17, 2025
Merged

feat: changed accept pegin and pegout reponse status #631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3c559
feat: changed accept pegin and pegout reponse status
gsoares85 Feb 14, 2025
3399496
feat: changed response code for expired quote
gsoares85 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/adapters/entrypoints/rest/handlers/accept_pegin_quote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func NewAcceptPeginQuoteHandler(useCase *pegin.AcceptQuoteUseCase) http.HandlerF
acceptedQuote, err := useCase.Run(req.Context(), acceptRequest.QuoteHash)
if errors.Is(err, usecases.QuoteNotFoundError) ||
errors.Is(err, usecases.ExpiredQuoteError) {
jsonErr := rest.NewErrorResponseWithDetails("invalid request", rest.DetailsFromError(err), true)
rest.JsonErrorResponse(w, http.StatusBadRequest, jsonErr)
jsonErr := rest.NewErrorResponseWithDetails("quote not found", rest.DetailsFromError(err), true)
rest.JsonErrorResponse(w, http.StatusNotFound, jsonErr)
Copy link
Copy Markdown
Collaborator

@Luisfc68 Luisfc68 Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will return 404 also when the quote is expired, shouldn't that scenario maintain the 400?

Copy link
Copy Markdown
Contributor

@MaximStanciu8 MaximStanciu8 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to differentiate the error code

return
} else if errors.Is(err, usecases.NoLiquidityError) {
jsonErr := rest.NewErrorResponseWithDetails("not enough liquidity", rest.DetailsFromError(err), true)
Expand Down
4 changes: 2 additions & 2 deletions internal/adapters/entrypoints/rest/handlers/accept_pegout_quote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func NewAcceptPegoutQuoteHandler(useCase *pegout.AcceptQuoteUseCase) http.Handle
acceptedQuote, err := useCase.Run(req.Context(), acceptRequest.QuoteHash)
if errors.Is(err, usecases.QuoteNotFoundError) ||
errors.Is(err, usecases.ExpiredQuoteError) {
jsonErr := rest.NewErrorResponseWithDetails("invalid request", rest.DetailsFromError(err), true)
rest.JsonErrorResponse(w, http.StatusBadRequest, jsonErr)
jsonErr := rest.NewErrorResponseWithDetails("invalid quote hash", rest.DetailsFromError(err), true)
rest.JsonErrorResponse(w, http.StatusNotFound, jsonErr)
return
} else if errors.Is(err, usecases.NoLiquidityError) {
jsonErr := rest.NewErrorResponseWithDetails("not enough liquidity", rest.DetailsFromError(err), true)
Expand Down
Loading