Support for adding annotations to deployments in Connect#794
Open
SamEdwardes wants to merge 1 commit intomainfrom
Open
Support for adding annotations to deployments in Connect#794SamEdwardes wants to merge 1 commit intomainfrom
SamEdwardes wants to merge 1 commit intomainfrom
Conversation
lucasrod16
reviewed
Mar 4, 2026
Contributor
lucasrod16
left a comment
There was a problem hiding this comment.
This makes sense to me given the use case described in #793. Could you add a couple of helm unit tests to help prevent regressions? These cases should cover it:
- No annotations on the deployment by default
- Annotations are applied when
deployment.annotationsis set
Here are some test cases for the chronicle chart for reference:
helm/charts/posit-chronicle/tests/metadata_test.yaml
Lines 68 to 80 in 87ae10f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #793
Hey Posit Connect team, could you please review this PR. Details on the use case or in the issue mentioned above.
I deployed Connect using this chart and verified that the annotations correctly get set on the deployment: