Skip to content

Support for adding annotations to deployments in Connect#794

Open
SamEdwardes wants to merge 1 commit intomainfrom
annotations-on-deployments
Open

Support for adding annotations to deployments in Connect#794
SamEdwardes wants to merge 1 commit intomainfrom
annotations-on-deployments

Conversation

@SamEdwardes
Copy link
Contributor

@SamEdwardes SamEdwardes commented Mar 2, 2026

Closes #793


Hey Posit Connect team, could you please review this PR. Details on the use case or in the issue mentioned above.

I deployed Connect using this chart and verified that the annotations correctly get set on the deployment:

# values.yaml
fullnameOverride: posit-connect

deployment:
  annotations:
    deployment-annotate: Nice its working
kubectl get deployment posit-connect -o json | jq '.metadata.annotations'
{
  "deployment-annotate": "Nice its working",
  "deployment.kubernetes.io/revision": "18",
  "meta.helm.sh/release-name": "posit-connect",
  "meta.helm.sh/release-namespace": "samedwardes-posit-team"
}

@SamEdwardes SamEdwardes requested a review from a team as a code owner March 2, 2026 21:28
@SamEdwardes SamEdwardes requested review from dbkegley and tdstein March 3, 2026 23:46
Copy link
Contributor

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me given the use case described in #793. Could you add a couple of helm unit tests to help prevent regressions? These cases should cover it:

  • No annotations on the deployment by default
  • Annotations are applied when deployment.annotations is set

Here are some test cases for the chronicle chart for reference:

- it: should skip annotations by default
asserts:
- notExists:
path: metadata.annotations
- it: should apply custom annotations if specified
set:
commonAnnotations:
another: annotation
asserts:
- isSubset:
path: metadata.annotations
content:
another: annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for adding annotations to deployment spec

2 participants