Fix: don't create .Random.seed as side effect of loading shiny#4383
Merged
Conversation
Only call `httpuv::getRNGState()` when restoring a pre-existing `.Random.seed`, avoiding RNG state creation when none existed before. Fixes #4382
.Random.seed as side effect of loading shiny
cpsievert
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4382
Summary
Loading shiny in a fresh R session (where
.Random.seeddoesn't yet exist) caused.Random.seedto be created as a side effect. This happened becausewithPrivateSeed()unconditionally calledhttpuv::getRNGState()on exit, which calls R's C-levelGetRNGstate()— and that function initializes the RNG (creating.Random.seed) when it doesn't already exist.The fix moves the
httpuv::getRNGState()call inside the branch that restores a pre-existing seed. When there was no.Random.seedbefore the call, we simply remove it and skip the sync — leaving the RNG in the same "not yet initialized" state it was in before package load.Test plan
test-utils.Rtests pass (seed save/restore behavior unchanged)