[Cop lazy loading] Fix application of MigrationFileSkippable to all cops#1619
Open
lovro-bikic wants to merge 1 commit into
Open
[Cop lazy loading] Fix application of MigrationFileSkippable to all cops#1619lovro-bikic wants to merge 1 commit into
MigrationFileSkippable to all cops#1619lovro-bikic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
MigrationFileSkippablemodule so it prepends toRuboCop::Cop::Baseinstead of prepending to each individual cop class.MigrationFileSkippableis meant to be applied to all cops, but this currently isn't the case if there are plugins loaded afterrubocop-rails. For example, if your RuboCop config is:rubocop-railswill be required beforerubocop-rspec, and whenRuboCop::Cop::Registry.all.eachruns,MigrationFileSkippablewon't be prepended torubocop-rspeccops because they haven't been added to the registry yet.This PR changes the implementation so that this module is instead prepended to
RuboCop::Cop::Base, thereby making it automatically available to all cops, regardless of when they're loaded.This PR is also a part of the cop lazy-loading proposal: rubocop/rubocop#14983. Not using
Registry.allis a prerequisite for lazy-loading to work with this gem.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.