Skip to content

[Cop lazy loading] Fix application of MigrationFileSkippable to all cops #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lovro-bikic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Cop lazy loading] Fix application of MigrationFileSkippable to all cops #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/fix_prepend_migration_file_skippable.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#1619](https://github.com/rubocop/rubocop-rails/pull/1619): Fix `MigratedSchemaVersion` setting so it works for all cops. ([@lovro-bikic][])
3 changes: 2 additions & 1 deletion lib/rubocop-rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
require_relative 'rubocop/cop/rails_cops'

require_relative 'rubocop/rails/migration_file_skippable'
RuboCop::Rails::MigrationFileSkippable.apply_to_cops!

RuboCop::Cop::Base.prepend(RuboCop::Rails::MigrationFileSkippable)

RuboCop::Cop::Style::HashExcept.minimum_target_ruby_version(2.0)

Expand Down
4 changes: 0 additions & 4 deletions lib/rubocop/rails/migration_file_skippable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ def add_offense(node_or_range, message: nil, severity: nil, &block)
super if method(__method__).super_method
end

def self.apply_to_cops!
RuboCop::Cop::Registry.all.each { |cop| cop.prepend(MigrationFileSkippable) }
end

private

def already_migrated_file?
Expand Down