Open
Conversation
jamirvin
reviewed
Feb 5, 2026
| int depth = nodes.Length - 1; | ||
| string lastNode = nodes[nodes.Length - 1]; | ||
|
|
||
| if (Config.FieldsToSkip.Contains(lastNode)) |
There was a problem hiding this comment.
Could you explain this a bit more? We've had to exclude fields from Autofield previously, why is this logical change needed now but was not previously?
Collaborator
Author
There was a problem hiding this comment.
Earlier only did it as part of FragmentFactory.InitializeToDefaultValues() which was getting used by few cmdlets. There were test-failures as part of weekly pwsh automatic-schema-update pipeline, that's how I detected it. It was done as part of #201, as mentioned in the description.
But it was not done in AutoField earlier, so doing it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There we 2 code paths in concern here.
Get-RscFileset.Recently we had following two fields introduced in schema which automatically gets included in Autofield and started being initialised in
InitializeToDefaultValuesmethod, this started causing test-case failures and made cmdlets to fail as these fields are not GAed yet, so customers were getting permission issue.The 2nd part
FragmentFactory.InitializeToDefaultValues()was already solved byPR201
But 1st part still remain to be an issue.
This PR solves the first part, by skipping these field from being part of Autofield._Includes()
Test Plan
Ran following query and confirmed it's no longer including the Non-GAed fields.
JIRA
SPARK-700863