Skip to content

Skip no ga fields from autofield #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokirubrik wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Skip no ga fields from autofield #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions RubrikSecurityCloud/RubrikSecurityCloud.Common/Autofield.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ private static bool _Includes(string nodeName, bool isLeaf = false)
string[] nodes = nodeName.Split('.');
int depth = nodes.Length - 1;
string lastNode = nodes[nodes.Length - 1];

if (Config.FieldsToSkip.Contains(lastNode))
Copy link

@jamirvin jamirvin Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this a bit more? We've had to exclude fields from Autofield previously, why is this logical change needed now but was not previously?

Copy link
Collaborator Author

@lokirubrik lokirubrik Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier only did it as part of FragmentFactory.InitializeToDefaultValues() which was getting used by few cmdlets. There were test-failures as part of weekly pwsh automatic-schema-update pipeline, that's how I detected it. It was done as part of #201, as mentioned in the description.

But it was not done in AutoField earlier, so doing it now.

{
return false;
}
string parent = string.Join(".", nodes, 0, nodes.Length - 1);
lastNode = lastNode.ToLower();
parent = parent.ToLower();
Expand Down