tests: Use Flash output for a couple of tests#23151
tests: Use Flash output for a couple of tests#23151ChrisCPI wants to merge 2 commits intoruffle-rs:masterfrom
Conversation
ChrisCPI
force-pushed
the
update-gradient-outputs
branch
from
f700375 to
8f740c5
Compare
tests/tests/swfs/from_gnash/misc-ming.all/GradientFillTest/output.expected.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Here I'm getting slightly different colors in FP, like #9b6fad vs #9c70ad.
Which FP did you take these outputs from?
There was a problem hiding this comment.
I took the screenshots from Windows 10, then sent it over Discord and cropped it on my Mac, so it wouldn’t surprise me if that messed it up some. I can try a different approach later today.
There was a problem hiding this comment.
I'm not an expert, but it looks like the PNG has been converted from one color profile to another. Also be careful when sending pictures through such services as they will often reencode the image to save space. To make sure they are exactly the same, either use checksums or send them in an archive.
|
Also, you probably shouldn't embed color profiles in PNGs, it will only confuse users because the PNGs will show different colors than expected. |
kjarosh
added
A-tests
ChrisCPI
force-pushed
the
update-gradient-outputs
branch
from
8f740c5 to
2cd23e7
Compare
Use output from Flash Player
ChrisCPI
force-pushed
the
update-gradient-outputs
branch
from
2cd23e7 to
0267726
Compare
Use output from Flash Player
ChrisCPI
force-pushed
the
update-gradient-outputs
branch
from
0267726 to
0b71a5d
Compare
2 participants
Related to #23059