Skip to content

tests: Use Flash output for a couple of tests #23151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisCPI wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests: Use Flash output for a couple of tests #23151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c90fd69
tests: Fix visual/gradient_issue_9892
ChrisCPI Mar 1, 2026
0b71a5d
tests: Fix from_gnash/misc-ming.all/GradientFillTest
ChrisCPI Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified tests/tests/swfs/from_gnash/misc-ming.all/GradientFillTest/output.expected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/tests/swfs/from_gnash/misc-ming.all/GradientFillTest/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ known_failure.ruffle_check = false

[image_comparisons.output]
tolerance = 50
max_outliers = 200
max_outliers = 1809

[player_options]
with_renderer = { optional = true, quality = "low" }
with_renderer = { optional = true, quality = "high" }

[subtests.fp9]
output_path = "output.fp9.txt"
Expand Down
Binary file modified tests/tests/swfs/visual/gradient_issue_9892/output.expected.png
View file
Open in desktop
Copy link
Member

@kjarosh kjarosh Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I'm getting slightly different colors in FP, like #9b6fad vs #9c70ad.

Which FP did you take these outputs from?

Copy link
Contributor Author

@ChrisCPI ChrisCPI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the screenshots from Windows 10, then sent it over Discord and cropped it on my Mac, so it wouldn’t surprise me if that messed it up some. I can try a different approach later today.

Copy link
Member

@kjarosh kjarosh Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert, but it looks like the PNG has been converted from one color profile to another. Also be careful when sending pictures through such services as they will often reencode the image to save space. To make sure they are exactly the same, either use checksums or send them in an archive.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 3 additions & 2 deletions tests/tests/swfs/visual/gradient_issue_9892/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
num_frames = 1

[image_comparisons.output]
tolerance = 12
tolerance = 32
max_outliers = 2170

[player_options]
with_renderer = { optional = true, quality = "low" }
with_renderer = { optional = true, quality = "high" }
Loading